Closed GenevieveBuckley closed 1 year ago
Requested changes addressed. Should be good to merge when the CI tests pass
@jni when you get a sec could you merge this? Thanks
Done - good suggestions @jni
Hmmm I thought #150 would fix the build but it didn't... If anyone has ideas about that (@Czaki @aganders3 @tlambert03?) I would appreciate them! The build logs aren't very informative:
> raise CalledProcessError(retcode, process.args,
[1965](https://github.com/napari/cookiecutter-napari-plugin/actions/runs/4614369575/jobs/8157264751?pr=154#step:6:1968)
output=stdout, stderr=stderr)
[1966](https://github.com/napari/cookiecutter-napari-plugin/actions/runs/4614369575/jobs/8157264751?pr=154#step:6:1969)
E subprocess.CalledProcessError: Command '['pre-commit', 'run', '--all']' returned non-zero exit status 1.
from test_pre_commit_validity
in all configurations...
@jni the #156 is fixing pre-commit related things
The cookiecutter writer functions do not describe what inputs they expect adequately. This PR attempts to improve that.
In particular, it is confusing because the input
data
in functionwrite_single_image
is not the same type of object as the inputdata
in functionwrite_multiple
.I've used numpy style docstring formatting here, mostly because I didn't see enough other docstrings to know what docstring format I should use for this project. We can change it, of course.