Closed AJFSalomon closed 5 months ago
Thanks for pointing this out @AJFSalomon! If you have the time/capacity to make a PR to change this in the cookiecutter, it would be appreciated, but if not, that's ok too, we'll aim to implement a fix shortly. 🙏
Thanks for pointing this out @AJFSalomon! If you have the time/capacity to make a PR to change this in the cookiecutter, it would be appreciated, but if not, that's ok too, we'll aim to implement a fix shortly. 🙏
Just made the asked pull request 🙂 This is my first ever PR on GitHub, so feel free to tell me if anything is missing 😉
This is my first PR on GitHub
wow! Sorry for my lackadaisical suggestion, it's always hard to know what level of experience people are coming from without the risk of sounding condescending. But anyway it looks good to me! Having said this I'm not actually that familiar with the test setup of this repo, so it's possible some tests would fail, in which case, we would need to fix them. This can be done by just pushing more commits to the PR branch. But for now, it looks good! 😊 Thanks! 🙏
wow! Sorry for my lackadaisical suggestion, it's always hard to know what level of experience people are coming from without the risk of sounding condescending. But anyway it looks good to me! Having said this I'm not actually that familiar with the test setup of this repo, so it's possible some tests would fail, in which case, we would need to fix them. This can be done by just pushing more commits to the PR branch. But for now, it looks good! 😊 Thanks! 🙏
Looks like all the tests passed!
Anyway, no problem with your suggestion, it was a good learning opportunity 😉
Welcome to the project! 😃
When I run pre-commit on my cookiecutter-based Napari plugin project, ruff issues the following warning:
I've made the suggested changes to my project, but thought I'd file this quick issue so that the cookiecutter can also be updated accordingly.