napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins
BSD 3-Clause "New" or "Revised" License
67 stars 39 forks source link

Test failure introduced by #175 #182

Closed AJFSalomon closed 4 months ago

AJFSalomon commented 4 months ago

I updated my own plugin project with the timeout change in test_and_deploy.yml introduced in #175, and it caused the following test failure after git push:

Invalid workflow file: .github/workflows/test_and_deploy.yml#L23
The workflow is not valid. .github/workflows/test_and_deploy.yml (Line: 23, Col: 5): Unexpected value 'timeout'

I was able to replicate the bug twice by creating brand new plugin templates with slightly different parameters.

I fixed the bug in my own project by replacing timeout: 30 with timeout-minutes: 30. I will file a PR for this, but I figured it was good to also file an issue since the cookiecutter test procedure did not catch the problem.