napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins
BSD 3-Clause "New" or "Revised" License
67 stars 39 forks source link

Do not create special case for plugins named napari-foobar #187

Closed GenevieveBuckley closed 3 months ago

GenevieveBuckley commented 3 months ago

Can anyone tell me why this special case was written in the first place?

Either we have a really good reason for it, and add comments explaining the need for this special situation, OR We remove the special case treatment, and handle all plugins the same way.

jni commented 3 months ago

Since the tests are passing, I suggest we just merge this. (Smells like a hacky testing workaround, but evidently obsolete.) I've merged main to the branch just in case but if the tests pass we should just merge.