search

napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins
BSD 3-Clause "New" or "Revised" License
69 stars 41 forks source link

remove setup.py, use pyproject.toml #85

Closed tlambert03 closed 2 years ago

jni commented 2 years ago

Can we keep the setup.py shim? I can't remember the exact circumstances now, but I remember encountering some tooling that was unhappy when setup.py was missing, and it's the sort of error that a beginner might find incredibly confusing.

tlambert03 commented 2 years ago

The condition was that pip didn't support editable installs without it. But update pip and that's no longer an issue (Maybe a year now?)

Now all that an empty setup.py says is "I'd like to use setup tools to build my package", which is what the build_requires section of pyproject is for

tlambert03 commented 2 years ago

Can we keep the setup.py shim? I can't remember the exact circumstances now, but I remember encountering some tooling that was unhappy when setup.py was missing, and it's the sort of error that a beginner might find incredibly confusing.

@jni, did the explanation above about updating pip supporting editable install satisfy you? this is waiting on you

jni commented 2 years ago

Yup, thanks for reminding me. Let's go for it.