search

napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins
BSD 3-Clause "New" or "Revised" License
67 stars 39 forks source link

Merge branch 'main' into npe2 #91

Closed tlambert03 closed 2 years ago

tlambert03 commented 2 years ago

This brings over some of the changes that went into main recently. This is in prep for npe2 to become main, and the current main will become npe1-archive

tlambert03 commented 2 years ago

don't know why CI isn't running here. I added the npe2 branch to the triggers... @nclack, have they generally been running on this branch? or not yet?

tlambert03 commented 2 years ago

@nclack, have a look when you can

nclack commented 2 years ago

don't know why CI isn't running here

I believe the tests were failing for a bit due to lack of fixture support for npe2, but that got fixed when the dock_widget tests were revised.

tlambert03 commented 2 years ago

but they're still not running...

nclack commented 2 years ago

but they're still not running...

yeah, that's strange. I can see you added the npe2 branch to the trigger. Maybe the change needs to be done on main to see the tests run here? does default branch determine the branch triggers?

tlambert03 commented 2 years ago

Yeah I think you're right. Keep forgetting that