search

napari / cookiecutter-napari-plugin

Cookiecutter for napari plugins
BSD 3-Clause "New" or "Revised" License
67 stars 39 forks source link

tox.ini change for gh-actions #98

Closed nickdelgrosso closed 2 years ago

nickdelgrosso commented 2 years ago

Hi,

Love the cookie-cutter, thank you for such a great project! For some reason, the python interpreter wasn't being detected in github actions, and my tests were failing. Making the change described in the following stackoverflow article fixed it: https://stackoverflow.com/a/68413752

Not experienced with tox, so not sure if there's a better way, but wanted to share it in case it helped others.

Best wishes,

Nick

tlambert03 commented 2 years ago

thanks! Can you link to the failing tests perchance? I'd be curious to see them, I do think that lacking generally lacking 3.10: py310 might have been problematic as well (though I also see that this fixed other's issues in that SO post). generally speaking the values on the right of of [gh-actions] python = are tox factors, and we use py39, py310 as our factors.

also: it would be nice to know use the documented usage of tox-gh-actions if at all possible

tlambert03 commented 2 years ago

could you also test in your own repo whether the following works?

[gh-actions]
python =
    3.7: py37
    3.8: py38
    3.9: py39
    3.10: py310