napari / docs

Documentation for napari (other than API docs)
BSD 3-Clause "New" or "Revised" License
9 stars 37 forks source link

'Depends on' does not work when added later #419

Open lucyleeow opened 2 months ago

lucyleeow commented 2 months ago

🐛 Bug

It seems that the 'Depends on' CI check does not work if you edit the OP later and add it, see https://github.com/napari/docs/pull/416.

Not super important though.

brisvag commented 2 months ago

Unfortunatelt you have to retrigger it manually (I just did it) for it to work, or push some new commit, otherwise the workflow won't run!

psobolewskiPhD commented 2 months ago

Could do something like the edit_pr_description: https://github.com/napari/docs/blob/main/.github/workflows/edit_pr_description.yml

The idea being to also trigger the check when the PR description is edited.

Actually that's what the docs for the action have:

on:
  pull_request_target: 
    types: [opened, edited, closed, reopened]

jobs:
  check_dependencies:
    runs-on: ubuntu-latest
    name: Check Dependencies
    steps:
    - uses: gregsdennis/dependencies-action@main
      with:
        custom-domains: my-custom-domain.io another.domain.com
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
melissawm commented 2 months ago

The complete options list is here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request