search

napari / docs

Documentation for napari (other than API docs)
BSD 3-Clause "New" or "Revised" License
9 stars 37 forks source link

Replace use of properties with features #425

Closed andy-sweet closed 2 weeks ago

andy-sweet commented 3 weeks ago

References and relevant issues

Part of https://github.com/napari/napari/issues/3911

Description

This replaces use of properties, property_choices, and current_properties with features and feature_defaults. The motivation for doing this now is to make the latest documentation consistent with existing code and examples on main (here and on napari/napari) for the upcoming v0.5 release. As we also plan to deprecate properties in v0.5 (https://github.com/napari/napari/issues/3911), this documentation update is necessary for that.

jni commented 3 weeks ago

Cool, thanks @andy-sweet! Let me know when you think this is ready for review! 🙏

andy-sweet commented 3 weeks ago

@jni: I have one last compatibility check to do with the btrack cell-tracking example, but other this is ready for review now.

andy-sweet commented 3 weeks ago

@jni: I have one last compatibility check to do with the btrack cell-tracking example, but other this is ready for review now.

Check is done.

andy-sweet commented 3 weeks ago

I think I addressed the feedback and also fixed a couple of links/cross-references. Please take another quick look before merging!

andy-sweet commented 3 weeks ago

Thanks for the second look. I'll merge this after the weekend unless anyone objects.

imagesc-bot commented 2 weeks ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/error-while-adding-text-to-napari/76960/5