Check knob and button IDs separately for conflicts

napari / midi-app-controller

Control napari with a MIDI controller.

BSD 3-Clause "New" or "Revised" License

1 stars 3 forks source link

Check knob and button IDs separately for conflicts #105

Closed jni closed 2 weeks ago

jni commented 2 weeks ago

Closes #104

As noted in #104 (comment), the validator attempts to ensure that the knob and button IDs are unique jointly, but the IDs of the knobs and those of the buttons actually overlap in the controller (see the controller definition here).

This PR therefore removes the Pydantic requirement for the button IDs to not clash with the knob IDs.

jni commented 2 weeks ago

@Czaki I think this is ready for review. 🙏