search

napari / midi-app-controller

Control napari with a MIDI controller.
BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

Refactor state manager #87

Closed lukaszsmolinski closed 6 months ago

lukaszsmolinski commented 6 months ago

Users should be able to use the library inside scripts, so I refactored the StateManager class a bit. I added some new methods (extracted from the GUI) and added tests, which raised the coverage to almost 100%.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 61.17647% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 49.62%. Comparing base (bd1b650) to head (546adf1).

Files Patch % Lines
midi_app_controller/gui/midi_status.py 0.00% 28 Missing :warning:
midi_app_controller/gui/utils.py 33.33% 4 Missing :warning:
midi_app_controller/state/state_manager.py 97.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ========================================== + Coverage 43.17% 49.62% +6.45% ========================================== Files 15 15 Lines 1047 1066 +19 ========================================== + Hits 452 529 +77 + Misses 595 537 -58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lukaszsmolinski commented 6 months ago

The reviewers did not express a willingness to conduct the review.