search

napari / napari-console

A plugin that adds a console to napari
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

Hide napari import #10

Closed tlambert03 closed 3 years ago

tlambert03 commented 3 years ago

Moves import napari inside _update_theme. This let's napari be an "optional" dependency, and will let us keep napari only in the testing requirements

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 (b946e6a) into main (95c5ba0) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files           3        3           
  Lines         113      113           
=======================================
  Hits           94       94           
  Misses         19       19
Impacted Files Coverage Δ
napari_console/qt_console.py 79.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95c5ba0...2ba0f5b. Read the comment docs.

sofroniewn commented 3 years ago

Very nice, clever fix. Will merge now and press on