search

napari / napari-console

A plugin that adds a console to napari
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

Update API to not rely on deprecated feature. #19

Closed Carreau closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #19 (fc59ad9) into main (cd81e95) will decrease coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   83.89%   83.76%   -0.14%     
==========================================
  Files           4        4              
  Lines         118      117       -1     
==========================================
- Hits           99       98       -1     
  Misses         19       19
Impacted Files Coverage Δ
napari_console/qt_console.py 79.76% <100.00%> (-0.24%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Carreau commented 2 years ago

I'm not 100% on the context here

I commented on the relevant line that uses a deprecated API. I don't have any tight to merge anything here.

alisterburt commented 2 years ago

interesting, me neither... @napari/core-devs does anyone have write access here? If so could you also give me write access for the future? 🙂

Czaki commented 2 years ago

@sofroniewn ?

alisterburt commented 2 years ago

Thanks @Carreau and whoever gave me write access!