search

napari / napari-console

A plugin that adds a console to napari
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

Disconnect viewer on close #2

Closed sofroniewn closed 3 years ago

sofroniewn commented 3 years ago

We should disconnect viewer when closed, see connection here https://github.com/sofroniewn/napari-console/blob/328ae98d76ccff696ac5fb665eebf6e1193d0c36/napari_console/qt_console.py#L81-L82

disconnect should happen here

https://github.com/sofroniewn/napari-console/blob/main/napari_console/qt_console.py#L163-L174

sofroniewn commented 3 years ago

Done. It would be nice if one day our validator checked that any events connected or keybindings/ mouse bindings added by plugins are properly removed on close