napari / napari-console

A plugin that adds a console to napari

BSD 3-Clause "New" or "Revised" License

3 stars 12 forks source link

Update theme/style sheet handling to enable napari-console to use napari `font_size` setting #33

Open dalthviz opened 6 months ago

dalthviz commented 6 months ago

References and relevant issues

Closes #32

Description

Depends on/related to napari/napari#6753

A preview:

console_font_size

Notes

While working on this, I noticed that with napari latest main a deprecation warning appears (related with using the as_dict kwarg from the get_theme function). Added a note about that here.
To preserve compatibility with napari 0.4.x (at least 0.4.19) the previous logic was left. The new style_sheet kwarg added to the _update_theme method defines if the previous logic needs to be used (napari 0.5.0 will use the new style_sheet kwarg, see https://github.com/napari/napari/pull/6753)

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.77%. Comparing base (e2a8d71) to head (0b219dd).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== + Coverage 96.69% 96.77% +0.07% ========================================== Files 4 4 Lines 121 124 +3 ========================================== + Hits 117 120 +3 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jni commented 19 hours ago

@Czaki does @dalthviz's latest commit address your concerns?

Czaki commented 18 hours ago

I just installed this PR and I do not see any changes when update theme or font size.

I do not see connection to any proper signal in the code

dalthviz commented 11 hours ago

Did you check this alongside https://github.com/napari/napari/pull/6753 @Czaki ? I checked again and works for me on Windows 🤔 (although as mentioned I see a deprecation warning related with the as_dict kwarg):

console_font_size

Anyhow, maybe the work over https://github.com/napari/napari/pull/6753 and here is not the correct approach and these PRs should be closed?