napari / napari-console

A plugin that adds a console to napari
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

WIP: modernise package data and fix CI #36

Closed jni closed 19 hours ago

jni commented 22 hours ago
jni commented 22 hours ago

So I don't understand why tox doesn't install pyqt etc, given this line. @Czaki I think you were trying to explain what was wrong to me at eurasia meeting yesterday but I didn't quite grok it. Can you tell me what needs changing here? 🙏

Czaki commented 20 hours ago

PySide2 support python up to python 3.10, and we made pyside2 conditional dependency here https://github.com/napari/napari/blob/e8c41abf306e45dc06f8569f6bdd461386f15e92/pyproject.toml#L95

jni commented 20 hours ago

Ah. So what do you think about only testing pyqt in this repo?

jni commented 20 hours ago

what with qt6 bindings?

I suggest leaving that to a future PR after this one is green and merged and then merged into #18.