search

napari / napari-console

A plugin that adds a console to napari
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

add napari dependency #9

Closed sofroniewn closed 3 years ago

sofroniewn commented 3 years ago

This PR would add a napari dependency, which we need because we need the get_theme and stylesheet template here https://github.com/napari/napari-console/blob/main/napari_console/qt_console.py#L14

It would be nice if we could find another way to do this at some point, but we need it now, and it might help fix https://github.com/conda-forge/staged-recipes/pull/13773 cc @jni @tlambert03

codecov[bot] commented 3 years ago

Codecov Report

Merging #9 (09f382b) into main (95c5ba0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files           3        3           
  Lines         113      113           
=======================================
  Hits           94       94           
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95c5ba0...09f382b. Read the comment docs.

sofroniewn commented 3 years ago

Superseded by #10 which "hides" napari import in theme update