NImage constructor name collision (type)

napari / napari-core

BSD 3-Clause "New" or "Revised" License

5 stars 3 forks source link

NImage constructor name collision (type) #16

Closed kevinyamauchi closed 5 years ago

kevinyamauchi commented 5 years ago

The constructor for NImage takes type as an input argument to specify the image type (display/color map I think?). This collides with the Python built-in type() class. This isn't an issue for now, but we should probably rename it to be safe. Maybe itype (in the same vein as dtype)?

kevinyamauchi commented 5 years ago

I made the proposed changes in the PR #17. I'm still getting acquainted with the code base, so hopefully I didn't break anything...it would be great if somebody could review (it's a small change) then we can squash/merge.