napari / napari-core

BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fix NImage type name collision #17

Closed kevinyamauchi closed 5 years ago

kevinyamauchi commented 6 years ago

I changed the input argument name for image type in the NImage constructor from type to itype to avoid collision with the built-in type function (see issue #16). I didn't see any tests, but I think I fixed any instances where the NImage constructor is used (just in demo.py?).

kevinyamauchi commented 6 years ago

Hmm looks like I don't have permissions to merge. @royerloic, would you mind merging when you have a chance?

kne42 commented 5 years ago

Closing as no longer applicable.