napari / napari-plugin-manager

The napari plugin installation dialog and associated machinery

BSD 3-Clause "New" or "Revised" License

5 stars 5 forks source link

Move conda util to utils module and clean up code #13

Closed goanpeca closed 11 months ago

goanpeca commented 1 year ago

Description

Replacement for https://github.com/napari/napari/pull/5641

Fixes #16 Fix not showing conda on dropdown for non conda installs

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

Fixes https://github.com/napari/napari-plugin-manager/issues/16

How has this been tested?

[x] example: the test suite for my feature covers cases x, y, and z
[x] example: all tests pass with my change
[x] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings.

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable. For more information see our translations guide.

codecov[bot] commented 1 year ago

Codecov Report

Merging #13 (109713b) into main (1c94510) will decrease coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   90.72%   90.67%   -0.06%     
==========================================
  Files           5        7       +2     
  Lines        1165     1180      +15     
==========================================
+ Hits         1057     1070      +13     
- Misses        108      110       +2

Impacted Files	Coverage Δ
napari_plugin_manager/_tests/test_utils.py	`100.00% <100.00%> (ø)`
napari_plugin_manager/qt_plugin_dialog.py	`91.11% <100.00%> (-0.21%)`	:arrow_down:
napari_plugin_manager/utils.py	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes