search

napari / napari-plugin-manager

The napari plugin installation dialog and associated machinery
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Plugin manager does not respect the `visibility` field in the manifest #25

Open DragaDoncila opened 9 months ago

DragaDoncila commented 9 months ago

The current version of npe2 supports setting the visibility field in the plugin manifest to hidden if the plugin developer wants to keep the Framework:: napari classifier but not be discoverable on the napari hub and in the plugin manager. The napari hub is being updated to respect this field as we speak, but we should also update the plugin manager to respect this field and not display plugins with visibility: hidden in search results.

goanpeca commented 7 months ago

Thanks for the heads up @DragaDoncila, will work on a fix :)

Czaki commented 7 months ago

I think that we should update the server that gathers this information for us. So I think that this issue should be moved to https://github.com/napari/npe2api

goanpeca commented 7 months ago

That is a good suggestion indeed. You suggest that the info we query over at npe2api already only includes visible plugins? or that it contains that info over there and we still filter them directly on the plugin manager?

Czaki commented 7 months ago

I suggest that npe2api should not serve information about hidden plugins.