search

napari / napari-plugin-manager

The napari plugin installation dialog and associated machinery
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Fix constraint file creation and clean up logic on Windows #66

Open dalthviz opened 1 week ago

dalthviz commented 1 week ago

Fix constraing file creation and clean up logic by using tempfile.mkstemp returned file descriptor to handle constraint file operations. The previous logic was ignoring the returned file descriptor and instead directly using open via the temporary file path and missing to close the ignored file descriptor

Fixes #63

Edit: Move from using tempfile.mkstemp to tempfile.NamedTemporaryFile

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.88%. Comparing base (e1cee5e) to head (7d4547a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== - Coverage 86.89% 86.88% -0.01% ========================================== Files 9 9 Lines 1343 1342 -1 ========================================== - Hits 1167 1166 -1 Misses 176 176 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.