search

napari / napari-sphinx-theme

https://napari.org/napari-sphinx-theme
BSD 3-Clause "New" or "Revised" License
4 stars 10 forks source link

Either provide a Dark theme or don't have advertise a dark theme #124

Closed psobolewskiPhD closed 3 months ago

psobolewskiPhD commented 1 year ago

Related to #22 I use an extension (Noir in Safari) that darkens websites that don't have a dark mode to match my system settings: light during the day, dark at night. napari.org isn't darkened by this extention, because according to the extension it provides a dark mode. But t o my eyes, it's just the light mode. So I have to either manually override each time in the evening/night or have napari.org permanently-dark which I don't want either.

jni commented 1 year ago

Also related to #113 😞

melissawm commented 7 months ago

We can track this on #22 now that we don't advertise a dark mode anymore (I believe!)

psobolewskiPhD commented 7 months ago

My darkening extension is still detecting a Dark theme:

image

so it's not darkening the page. So somewhere, something is triggering. I will look into this some more later.

psobolewskiPhD commented 7 months ago

I see this in my Safari dev console: [Log] [PST]: Changed to auto mode using the light theme. (pydata-sphinx-theme.js, line 1) When I load with Light system theme. With Dark system theme it's ... dark theme So it looks like even though we don't offer a dark theme and the controls are disabled we are in auto mode.

Looking at docs: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/light-dark.html#light-and-dark-themes Maybe we just need to add:

html_context = {
   # ...
   "default_mode": "light"
}
melissawm commented 7 months ago

Argh. Thanks for checking!