search

napari / napari-sphinx-theme

https://napari.org/napari-sphinx-theme
BSD 3-Clause "New" or "Revised" License
4 stars 10 forks source link

H3 Header size in `magicgui.md` incorrectly rendered (small) #141

Closed lucyleeow closed 6 months ago

lucyleeow commented 7 months ago

🐛 Bug

The header size seems wrong here (and later in the document):

image

'Parameter annotations' is a level '3' header whereas 'Annotating as a Layer subclass' is a level '4' header, but above the level '4' header looks bigger? Code:

https://github.com/napari/docs/blob/4ebdd1614323727d0689fb8c9f4d5bba7accb632/docs/howtos/extending/magicgui.md?plain=1#L168-L183

Is this (potentially) a style theme problem @melissawm ?

psobolewskiPhD commented 7 months ago

That does look a bit strange. And I think it should be moved to the theme. Here's the code in the napari-sphinx-theme:

https://github.com/napari/napari-sphinx-theme/blob/f1ac9a397e0b12fb8b675e22e3a40204ca55ba9f/napari_sphinx_theme/static/css/napari-sphinx-theme.css#L627-L636

Looks like h3 size is overwriting the default of the theme with a smaller value, compare:

https://github.com/pydata/pydata-sphinx-theme/blob/8cf45f835bfdafc5f3821014a18f3b7e0fc2d44b/src/pydata_sphinx_theme/assets/styles/variables/_fonts.scss#L10-L15

Edit: not sure why the code isn't rendering!

lucyleeow commented 7 months ago

And I think it should be moved to the theme.

I wasn't certain it was due to the theme. I think you can transfer an issue: https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository I don't have the right access to do this though.

lucyleeow commented 7 months ago

Thanks for moving this!