napari / napari-sphinx-theme

https://napari.org/napari-sphinx-theme
BSD 3-Clause "New" or "Revised" License
4 stars 11 forks source link

"back to top" position is set as a percent when it should probably be absolute #150

Closed jni closed 9 months ago

jni commented 9 months ago

On vertical windows it's really high off the bottom of the page and quite annoying. 😅

Screenshot 2024-02-06 at 12 43 00 pm

You can verify that it's proportional by making it a appear (by scrolling up) then resizing the window vertically.

I'd actually consider removing it altogether — we have Home keys and/or Cmd-Up for this... having it pop up when I'm just doing a little bit of referring back to the last paragraph is quite distracting rather than helpful...

melissawm commented 9 months ago

Hmm this is probably a pydata sphinx theme issue, as I never set that. Could you open it upstream?

jni commented 9 months ago

Hot damn — it was just fixed upstream: pydata/pydata-sphinx-theme#1497 pydata/pydata-sphinx-theme#1616

It's the gift that keeps on giving! 😃

Looks like we can turn it off with "back_to_top_button": False in the theme config in conf.py starting with pydata-sphinx-theme v0.15.2. 😃