search

napari / napari-sphinx-theme

https://napari.org/napari-sphinx-theme
BSD 3-Clause "New" or "Revised" License
4 stars 10 forks source link

Level 4 header larger than level 3 header #158

Closed lucyleeow closed 5 months ago

lucyleeow commented 5 months ago

Level 4 header larger than level 3 header, "qtbot" is the level 4 header.

image

This is from the rendered docs in https://github.com/napari/docs/pull/378/files, but I've also checked this is the case in the asyn page.

Possibly related to https://github.com/napari/napari-sphinx-theme/issues/141 ?

Maybe @melissawm knows more? :pray:

melissawm commented 5 months ago

Argh thanks for reporting, will fix ASAP.

psobolewskiPhD commented 5 months ago

This is fixed by #141 see from most recent CI action artifact.

image

The reason you see it in napari/dev docs is because the theme hasn't been released since the fix.

melissawm commented 5 months ago

Oh you are right - I thought I had left something out in that pr. In that case, maybe we should review any pending items here and if there's no bugs or feature requests should we just cut a new release?

The only big items I can see are the calendar event location field, and the dark mode support issues. My preference would be to cut a release now an another one when those are fixed, just to get the already fixed issues out of the way. Wdyt @psobolewskiPhD @jni?

psobolewskiPhD commented 5 months ago

I think we're fine to release -- The dark/light we have the solution for but bug is upstream. And isn't the calendar javascript in napari/docs?

lucyleeow commented 5 months ago

Ah thank you!!