Remove PyData Sphinx Theme pin

napari / napari-sphinx-theme

https://napari.org/napari-sphinx-theme

BSD 3-Clause "New" or "Revised" License

4 stars 10 forks source link

Remove PyData Sphinx Theme pin #161

Closed melissawm closed 3 months ago

melissawm commented 4 months ago

Includes fixes for the primary sidebar compatible with PST 0.15.3

melissawm commented 3 months ago

That did not fix the nav bar decoration 😢 I'll come back to this tomorrow.

psobolewskiPhD commented 3 months ago

I re-ran CI since 15.3 has been released. Looking at the artifact:

https://github.com/napari/napari-sphinx-theme/issues/80 appears fixed 🎉 -- err, maybe not, see below the ToC is missing.
there is an annoying shift when mouse-over the top nav bar: when you mouse over the whole bar shifts up a few pixels
the black highlight bar is in a different spot
left-hand-size ToC is missing:

melissawm commented 3 months ago

Not sure what happened to the toc, but a lot has been merged in the past few days over at PST. For the other items - that's what I was trying to fix in my last commit. I'll take a look tomorrow.

melissawm commented 3 months ago

I think I got it, but we'll also need to update the docs, see https://github.com/napari/docs/pull/423

psobolewskiPhD commented 3 months ago

The nav bar looks fixed! You rock!

melissawm commented 3 months ago

With the latest commit to napari-docs this should be complete, including disabling the back-to-top button @jni

Let me know if you see any other glaring issues before we upgrade

psobolewskiPhD commented 3 months ago

I'd be ok with optimistically merging and releasing and then we see how it builds over there. Worst case there is some glitch in dev docs?

melissawm commented 3 months ago

There shouldn't be, but I'll be available to fix this weekend if that happens.

psobolewskiPhD commented 3 months ago

I have the Pacific meeting with Juan (and hopefully others!) this evening, so I'll bring this up then and maybe we can get it merged and released. If we're really concerned we could release without this (because a few small fixes were merged) and then merge and release this in it's own release?

melissawm commented 3 months ago

Thats up to you, I don't necessarily see an advantage in releasing without this PR

jni commented 3 months ago

That's what I think. 😜