search

napari / napari-tiff

A napari reader plugin for tiff images.
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

npe2 conversion (napari plugin engine 2) #11

Closed GenevieveBuckley closed 7 months ago

GenevieveBuckley commented 7 months ago

Migration to the new napari plugin engine 2 spec, see https://napari.org/stable/plugins/npe2_migration_guide.html#migrating-using-the-npe2-command-line-tool

jni commented 7 months ago

For some reason it's not detecting that I merged #10, would you mind merging in main manually (or git rebasing on main) so only the relevant changes are visible?

GenevieveBuckley commented 7 months ago

Can you also remove the napari-plugin-engine dependency, imports, and decorators? I think the convert script still assumes that one wants to support both npe1 and npe2, but that is definitely not the case anymore.

Done. Do I need to add npe2 to the requirements.txt file?

jni commented 7 months ago

Do I need to add npe2 to the requirements.txt file?

No, since we don't import from npe2!

We will need to add the yml to the manifest, but let me do that in a separate PR where I plan to update setup.py to pyproject.toml.

jni commented 7 months ago

(Unless you want to do it here so it stays consistent...)

GenevieveBuckley commented 7 months ago

What do you prefer? (I did make an issue here about pyproject.toml https://github.com/napari/napari-tiff/issues/13)

jni commented 7 months ago

I don't mind leaving it till the fix of #13. In we go! 😊