search

napari / napari-tiff

A napari reader plugin for tiff images.
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Follow scientific python project suggestion #20

Closed Czaki closed 4 months ago

Czaki commented 8 months ago

I think that it will be worth to follow this rules.

https://learn.scientific-python.org/development/guides/repo-review/?repo=napari%2Fnapari-tiff&branch=main

jni commented 8 months ago

Cool! Yup, agreed, though it's silly that it can't find the tests directory, which does in fact exist.

Czaki commented 8 months ago

They assume either use top level test directory or src layout.

GenevieveBuckley commented 4 months ago

We are very happy to receive PRs with any of the suggested improvements. I encourage anybody interested to submit one.

However, I am going to close this issue. I don't consider this a bug, especially since many (or all?) of the napari org repos also do not pass this particular tool's set of checks (and as far as I'm aware, don't have a goal of pursuing that either). Since this isn't actively being worked on, a tracking issue isn't necessary for now.