napari / napari.github.io

website for the napari image viewer
https://napari.org/
44 stars 43 forks source link

Take 2: Fix the calendar via fix `napari-calendar` in the .md #373

Closed psobolewskiPhD closed 2 years ago

psobolewskiPhD commented 2 years ago

OK, so https://github.com/napari/napari.github.io/pull/372 fixed the link, but not the calendar that is displayed. đŸ˜” The .md file doesn't have a calendar-id, so I'm fixing that here. But the .html just has:

<div class="napari-calendar show-filters docutils">
</div>

So the calendar is autogenerated... But will the docs be rebuilt from the .md if the PR is merged? Or is there something else? Is it possible to download a preview of the PR-built docs? Still confused how this repo works, to be honest.

melissawm commented 2 years ago

Nope - nothing on this repo is built. All of this content comes from building the docs from either napari/napari or napari/docs. The old versions of the docs in this repo are served directly from the built html, so if you want this change to be effective you need to re-build the entire stable docs locally, and upload the html files. I can do that, if this is the right fix - but the whole idea is that we don't backport too much into the "frozen" versions of the docs. Hopefully after dev becomes stable, we will see a lot less issues as they are all being fixed on dev.

psobolewskiPhD commented 2 years ago

@melissawm thanks for the explanation. I think I get it now? In that case this won't fix anything. I find the broken calendar really irritating daily, having to remember to switch to the dev version of the site. But because it's not an easy fix and it should be fixed when 0.4.17 is released—am I right?—then best to close this.

melissawm commented 2 years ago

Unfortunately I'm not too familiar with the google calendar set up so I don't know how to fix this - and yes, this should work from 0.4.17 on.