napari / napari.github.io

website for the napari image viewer
https://napari.org/
44 stars 43 forks source link

[Meeting Schedule] Calendar is broken #374

Closed lmarcos closed 1 year ago

lmarcos commented 2 years ago

šŸ› Bug

Calendar page is broken

To Reproduce

Steps to reproduce the behavior:

  1. Go to Community -> Meeting Schedule
  2. Pay attention to calendar

Expected behavior

Calendar is overlapping text underneath

Environment

This is affecting versions 4..16 and 4.17 - MAC 13.0 Safari 16.1

image
Czaki commented 2 years ago

On Ubuntu Firefox it works. Could you provide more details like OS and Browser?

lauramarcos commented 2 years ago

MAC 13.0 Safari 16.1 @Czaki

melissawm commented 2 years ago

Is this related to napari/napari#371 or napari/napari#358?

lauramarcos commented 2 years ago

@melissawm this is related to https://github.com/napari/napari.github.io/issues/371

melissawm commented 1 year ago

Ok - now that 0.4.17 is stable, the calendar appears there correctly: https://napari.org/stable/community/meeting_schedule.html

It will still be broken for 0.4.16, though, because I haven't backported the napari-sphinx-theme to that version of the docs. Do we want to go back and fix that too?

psobolewskiPhD commented 1 year ago

IMO someoneā€”like meā€”looking for the meeting calendar won't be poking around old versions? So it's not so crucial? Maybe better to implement a banner that informs the version is out-datedā€”I thought there was an issue for this, but can't find anywhere.

melissawm commented 1 year ago

The discussion on the warning banner for the old docs is here https://github.com/napari/docs/issues/82

I just updated with the latest from PyData Sphinx theme.

psobolewskiPhD commented 1 year ago

So the 0.4.18 stable docs have the jumbled calendar again. dev looks fine, as does 0.4.17 0.4.16 is broken as expected, but fine. Any ideas @melissawm ? I assume something was missed in the porting of stuff back to napari/napari for the release.

melissawm commented 1 year ago

Sorry yes, I will try to fix this soon

melissawm commented 1 year ago

Fixed by #389