napari / napari.github.io

website for the napari image viewer
https://napari.org/
44 stars 43 forks source link

[Safari 16.4, macOS] Spinning video on homepage, stable docs only #387

Closed psobolewskiPhD closed 1 year ago

psobolewskiPhD commented 1 year ago

Stable (0.4.18) napari.org:

image

Spins for >30 min and never loads the video. What's odd, is latest works immediately basically:

image
jni commented 1 year ago

(a) I can reproduce (b) that is indeed bizarre because I just checked and the html around the video element is indeed identical! 🤯 So some other js or something must be breaking the video tag for safari on the main page... Gah!

jni commented 1 year ago

Here's the issue:

https://github.com/napari/napari.github.io/blob/gh-pages/0.4.18/_static/images/tribolium.webm

the webm is still the lfs pointer, not the file.

jni commented 1 year ago

should I just push the file?

jni commented 1 year ago

On dev the file is there: https://github.com/napari/napari.github.io/blob/gh-pages/dev/_static/images/tribolium.webm

melissawm commented 1 year ago

Shoot, I though I had fixed every LFS thing, it's interesting that this didn't show up when I queried the local LFS files. Here's a fix: https://github.com/napari/napari.github.io/pull/388