search

napari / napari.github.io

website for the napari image viewer
https://napari.org/
44 stars 43 forks source link

Add deployment trigger to unversioned pages workflow #404

Closed melissawm closed 2 months ago

melissawm commented 2 months ago

The unversioned pages workflow is not being triggered by pages deployment from napari/napari or napari/docs. I believe this deployment is not a "push" event to the gh-pages branch, but a "deployment" event.

This PR adds the deployment trigger to the workflow.

See https://docs.github.com/en/webhooks/webhook-events-and-payloads#deployment

melissawm commented 2 months ago

Friends, I will merge as there's really no way to test this otherwise. Fingers crossed!

melissawm commented 2 months ago

This didn't work 😭 I'll do some more research tomorrow.

Nothing is broken - but the unversioned pages action can only be run manually at this time.

psobolewskiPhD commented 2 months ago

Wierd, the deploy action in docs sure looks like it's doing a git push: https://github.com/napari/docs/actions/runs/9751575893/job/26913825416#step:4:1494

psobolewskiPhD commented 2 months ago

Maybe we need this one: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#page_build

melissawm commented 2 months ago

Yes, maybe. I'll open a new PR. Thanks again 🙏🏻