search

napari / napari

napari: a fast, interactive, multi-dimensional image viewer for python
https://napari.org
BSD 3-Clause "New" or "Revised" License
2.07k stars 410 forks source link

Do not crash test on graphviz installation fail #6837

Closed Czaki closed 1 month ago

Czaki commented 1 month ago

References and relevant issues

Description

In #6554 I have added the graphviz installation step to produce a leaked widgets graph. Unfortunately, brew is reporting some errors on installing python 3.12 during installation of graphviz.

This PR makes graphviz installation steep optional. So in post cases we will still have leaked widgets graph, but do not crash the test suite.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.39%. Comparing base (66176ed) to head (7c30c8d). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6837 +/- ## ========================================== - Coverage 92.41% 92.39% -0.02% ========================================== Files 615 615 Lines 54915 54915 ========================================== - Hits 50747 50740 -7 - Misses 4168 4175 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

psobolewskiPhD commented 1 month ago

Looking at the errors, maybe it's worth trying the graphviz setup before the python setup step?