Closed brisvag closed 1 week ago
Hmm, I don't see the donut effect anymore, but I also don't see the highlight at all. I changed thickness to 3 as well.
a
to select all.Do the selection markers need to be canvas_size + highlight thickness?
Good point... what about now?
Attention: Patch coverage is 80.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 92.39%. Comparing base (
caf6caf
) to head (e395597
). Report is 15 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
napari/_vispy/visuals/points.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The behavior seems good now. I did notice that the highlight scales with zoom differently than point size, but the same behavior happens on main.
References and relevant issues
Closes https://github.com/napari/napari/issues/6682
Description
The selection markers were not updated accordingly.
This is still not perfect (zooming in and out beyond the limits will change the thickness of the highlight), but it's a limitation of how hilight is implemented (by just using extra markers). Ideally we want to have a single marker take care of hilight as well, but this requires rewriting the shaders and it's not trivial.