search

napari / napari

napari: a fast, interactive, multi-dimensional image viewer for python
https://napari.org
BSD 3-Clause "New" or "Revised" License
2.07k stars 410 forks source link

Ensure bounding_box lines stay up to date between 2D and 3D #6855

Closed brisvag closed 4 weeks ago

brisvag commented 4 weeks ago

References and relevant issues

Fixes #6852.

Description

The overlay already had this mechanism to ensure the vertex points stayed up to date; I just forgot to do the same for lines.

I also removed a superfluous line that was left over from a previous implementation.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.39%. Comparing base (bdfac3c) to head (e4cb385).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6855 +/- ## ========================================== - Coverage 92.44% 92.39% -0.06% ========================================== Files 614 614 Lines 54840 54843 +3 ========================================== - Hits 50699 50672 -27 - Misses 4141 4171 +30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.