Closed Czaki closed 3 weeks ago
Attention: Patch coverage is 31.81818%
with 30 lines
in your changes are missing coverage. Please review.
Project coverage is 92.35%. Comparing base (
283be74
) to head (c8ee411
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
napari/_qt/_qapp_model/injection/_qproviders.py | 26.92% | 19 Missing :warning: |
napari/layers/_layer_actions.py | 26.66% | 11 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I dig it, I mean the contextual menu position should be moved down and I would add ...
to mark that modal will open, but it looks cool.
Edit: with this I'd probably also suggest a Set scale..
which pops a modal to enter the scale, again the most common use case. Transform can be done in GUI now, but not setting scale.
Could consider putting this in a submenu along with reset scale & transform
to go back to 1, 1, 1.
Thinking out loud about other approaches:
Copy
action on a layer that would grab that info and then offer a Apply
action you could use on any other layers. I think it could be a bit more handy if you have many layers, but not sure on the implementation side how tricky it would be.Set scale as global
action, that would apply the selected layer's scale to all layers -- this is probably the most common use case? (Could be handy programmatically too, TBH) Again, maybe in a submenu with reset
Edit: with this I'd probably also suggest a
Set scale..
which pops a modal to enter the scale, again the most common use case.
I have planned to do this in separate PR for editing spatial properties.
Transform can be done in GUI now, but not setting scale.
How?
could try to do a
Copy
action on a layer that would grab that info and then offer aApply
action you could use on any other layers. I think it could be a bit more handy if you have many layers, but not sure on the implementation side how tricky it would be.
It may be implemented using json (copy json to the clipboard and paste it back). But it may be difficult to discover. But maybe I have wrong image in my head and it could be obvious to to discover??
But it may be difficult to discover.
No more difficult to discover than any other layer list contextual menu item? I think right-click copy and then paste/apply are pretty common actions across OS's too-and MS Office apps for sure. 🤷
Close in favor of #6864 base on feedback of community meeting
References and relevant issues
depends on https://github.com/pyapp-kit/in-n-out/pull/110
Description
Currently, we do not provide any mechanism to adjust spatial information from GUI. This PR add option to copy information from one layer to list of another one (selection).
https://github.com/napari/napari/assets/3826210/4152aa06-00cf-4360-826f-5f6959328e02
Currently, it only copies
scale
andtranslate
, as I would like to ask if you are happy with such workflow.This workflow requires opening a modal window to select the source layer.
It is part of #6780