napari / napari

napari: a fast, interactive, multi-dimensional image viewer for python
https://napari.org
BSD 3-Clause "New" or "Revised" License
2.07k stars 410 forks source link

Fix compile constraints by compile per operating system and using `uv` #6873

Closed Czaki closed 2 weeks ago

Czaki commented 3 weeks ago

References and relevant issues

Workaround for the problem described here: https://github.com/napari/napari/pull/6858#issuecomment-2073584997

Description

Use uv instead of pip-tools for faster compilation and support of targeting python version and os.

Czaki commented 3 weeks ago

For current state 16 😜 But the i would like to check if they really different. And maybe it will only 8 or even less

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.41%. Comparing base (5527240) to head (5543bb6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6873 +/- ## ========================================== - Coverage 92.43% 92.41% -0.02% ========================================== Files 614 614 Lines 54903 54903 ========================================== - Hits 50748 50741 -7 - Misses 4155 4162 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Czaki commented 3 weeks ago

pushing this forward requires to fix handling macos-arm in uv https://github.com/astral-sh/uv/pull/3267

brisvag commented 2 weeks ago

pushing this forward requires to fix handling macos-arm in uv astral-sh/uv#3267

released!

Czaki commented 2 weeks ago

@brisvag it is ready for review

psobolewskiPhD commented 2 weeks ago

Pretty wild that the action used to take ~9 min and now it's 25 s.

Czaki commented 2 weeks ago

Pretty wild that the action used to take ~9 min and now it's 25 s.

This speedup is a reason why I started these migration.

brisvag commented 2 weeks ago

Great work!