search

napari / napari

napari: a fast, interactive, multi-dimensional image viewer for python
https://napari.org
BSD 3-Clause "New" or "Revised" License
2.07k stars 410 forks source link

Fix benchmark reporting #6877

Closed Czaki closed 2 weeks ago

Czaki commented 2 weeks ago

Description

This Pr fixes benchmark result reporting by adding the step of combining workflow artifacts into a single archive and adding permissions to benchmark_report.yml workflow. It cannot be fully tested without merging. Partial merge was present in, #6875

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.42%. Comparing base (5527240) to head (dbf1fe1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6877 +/- ## ========================================== - Coverage 92.43% 92.42% -0.02% ========================================== Files 614 614 Lines 54903 54903 ========================================== - Hits 50748 50742 -6 - Misses 4155 4161 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

psobolewskiPhD commented 2 weeks ago

Maybe add:

  push:
    paths:
      - '.github/workflows/benchmarks**'

to benchmarks.yml? Then if there is a follow-up it might be easier?

Czaki commented 2 weeks ago

to benchmarks.yml? Then if there is a follow-up it might be easier?

As the trigger is only to add a label and a single run is 3h of CI work, I'm not sure if it is required.

Czaki commented 2 weeks ago

It works again https://github.com/napari/napari/pull/6727#issuecomment-2085363545