search

napari / napari

napari: a fast, interactive, multi-dimensional image viewer for python
https://napari.org
BSD 3-Clause "New" or "Revised" License
2.07k stars 410 forks source link

[bugfix] Drop if guard on notification_manager to enable show_info from Jupyter #6882

Closed psobolewskiPhD closed 1 day ago

psobolewskiPhD commented 2 weeks ago

References and relevant issues

Closes https://github.com/napari/napari/issues/6455

Description

The if statement removed was supposed to block ipython, but wasn't doing that. Dropping it so that notifications JustWork.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.43%. Comparing base (f66fce6) to head (de87f32).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6882 +/- ## ========================================== - Coverage 92.45% 92.43% -0.02% ========================================== Files 617 617 Lines 55156 55155 -1 ========================================== - Hits 50993 50984 -9 - Misses 4163 4171 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

psobolewskiPhD commented 2 weeks ago

@LucaMarconato Can you give this branch a shot in your use-case?

LucaMarconato commented 2 weeks ago

Works for me! Thanks a lot 😊