Closed Czaki closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.44%. Comparing base (
36bb0d3
) to head (82e6fd6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @Czaki!
Additionally I would like to reorder the author list — if it has to be automatic then I suggest by number of commits, but I'm open to other suggestions, including e.g. 1st core devs alphabetical then by commits. But all alphabetical is very weird. Personally I think "Sofroniew N, Lambert T, et al" is still a good reference for now.
(of course, this can come in a different PR.)
Can we manually trigger the entry on zenodo for 0.4.19?
Apparently you can manually edit Zenodo entries so I'll try to get in touch with Nick (who I believe set this up back in the day) to see if we can put credentials/ownership in the joint 1Password account and then we can edit the entry. But let's get the metadata being generated correctly on main first.
Yup I mean after this PR :P I'd say let's merge immediately, not much controversial here.
if it has to be automatic then I suggest by number of commits (of course, this can come in a different PR.)
Not so many commits left.
In general, this is manual (I use a simple script for sort). I may think to develop script for updating and validate citation.cff
(to fail CI when author is not added to citation file).
But in such a situation we may think to switch from CITATION.cff
to .zenodo.json
as it offer two roles (creator and contributtror) https://developers.zenodo.org/#representation
In the past, a few persons (for example, Robert Hasse rejected to be added to citation file as they felt that contribution was too small).
If we still use CITATION.cff I prefer order:
1) Core-dev 2) emeritus core-dev 3) other contributors
Each group alphabetically.
@jni What are your preferences to above statements?
I need to think about it, which is why I decided to just merge. 😂
I need to think about it, which is why I decided to just merge. 😂
May you open issue with this problem? I think that you could better summarize it and it will be easier to point problem to other core devs.
Description
We have a problem that there is no entry on zenodo for napari for 0.4.19 release line. It lokks like some PR (most probably mine) broke the citation cff format.
I have validated and fixed field based on
cffconvert
python package. I also added GitHub actions for validate file content based on official documentaion https://github.com/citation-file-format/citation-file-format/blob/main/README.mdI'm not 100% sure that it will be enough to fix it, but it looks required for that.