4dsound nap pr january 2020

[stijnvanbeek]

These are a couple of changes to the NAP repository made by 4DSOUND:

these will concern Naivi most:

• The AppRunner shuts down the services when the initialization fails, to ensure shutdown() is always called when init() has succeeded.
• The Parameter::setValue() functions are exposed to rtti, so they can be called form python scripts.

And these less so, as they are mainly audio changes:

• The signature of audio::MultiInputPin::pull() method has changed, so the caller has the responsibility to manage the destination buffer. This solves some threadsafety concerns while parallel processing audio.
• The host API index is passed to AudioService::openStream() method, to make sure it is updated internally when the device settings change at runtime.
• A simplification in the SafeOwner/SafePtr/DeletionQueue system, that is possible now because in NAP 0.4 order of shutdown/destruction of services is now guaranteed to mirror the service dependency graph.
• An couple of adaptations in utility/threading.h: classes are marked with NAPAPI macro to use them across DLL bounds on windows, threadpools can be marked realtime, in order to spawn their threads with realtime priority.

[cklosters]

Thanks for the PR. Because auto PR building is not installed for the public repo it's hard to verify the changes cross platform. For now I enabled auto PR building for the public repo, because the number of PRs are limited. Best to push a change and see if the system picks it up. I can't let anything pass without cross-platform verification.

[cklosters]

[18:38:15]  [Step 2/2] naputility.lib(threading.obj) : warning LNK4217: locally defined symbol ?enqueue@TaskQueue@nap@@QEAAXV?$function@$$A6AXXZ@std@@@Z (public: void __cdecl nap::TaskQueue::enqueue(class std::function<void __cdecl(void)>)) imported in function "public: virtual __cdecl nap::WorkerThread::~WorkerThread(void)" (??1WorkerThread@nap@@UEAA@XZ) [44040c56bd2f12b7\nap\packaging_build\modules\napaudio\mod_napaudio.vcxproj]
[18:38:15]  [Step 2/2] naputility.lib(threading.obj) : warning LNK4217: locally defined symbol ??1TaskQueue@nap@@QEAA@XZ (public: __cdecl nap::TaskQueue::~TaskQueue(void)) imported in function "int `public: __cdecl nap::ThreadPool::ThreadPool(int,int,bool)'::`1'::dtor$4" (?dtor$4@?0???0ThreadPool@nap@@QEAA@HH_N@Z@4HA) [44040c56bd2f12b7\nap\packaging_build\modules\napaudio\mod_napaudio.vcxproj]
[18:38:15]  [Step 2/2] naputility.lib(threading.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) const nap::WorkerThread::`vftable'" (__imp_??_7WorkerThread@nap@@6B@) referenced in function "public: __cdecl nap::WorkerThread::WorkerThread(bool,int)" (??0WorkerThread@nap@@QEAA@_NH@Z) [44040c56bd2f12b7\nap\packaging_build\modules\napaudio\mod_napaudio.vcxproj]
[18:38:15]  [Step 2/2] 44040c56bd2f12b7\nap\packaging_bin\MSVC-x86_64-Release\mod_napaudio.dll : fatal error LNK1120: 1 unresolved externals [44040c56bd2f12b7\nap\packaging_build\modules\napaudio\mod_napaudio.vcxproj]

[cklosters]

[18:32:32]  [Step 2/2]44040c56bd2f12b7\nap\utility\src\utility\threading.cpp(14): warning C4273: 'nap::TaskQueue::TaskQueue': inconsistent dll linkage [44040c56bd2f12b7\nap\packaging_build\utility\naputility.vcxproj]
[18:32:32]  [Step 2/2] 44040c56bd2f12b7\nap\utility\src\utility\threading.h(32): note: see previous definition of '{ctor}' (compiling source file 44040c56bd2f12b7\nap\utility\src\utility\threading.cpp)

[cklosters]

Moving base of PR to public_beta. All PRs will be merged into public_beta until ready for release (tested).