Closed TimGroeneboom closed 1 month ago
Thanks for the PR, I'll have time to properly review it beginning of next month.
When I drag an event (make an edit) and try to re-load the change I get the following assert (Debug / MSVC):
https://github.com/user-attachments/assets/3fa81b94-5732-445a-9ad2-655cbbb3a0a4
When I drag an event (make an edit) and try to re-load the change I get the following assert (Debug / MSVC):
history_edit_error.mp4
good catch, weird the crash only occurs on msvc.
fix pushed -> https://github.com/napframework/nap/pull/29/commits/7c3fd050126366180186949bb4ae3bad8697cdf0
Thanks for the clarification @TimGroeneboom, this PR will be part of the 0.7.5 release and can be merged into main when the builds pass.
Merci! feel free to delete branch if you don't need it anymore.
See video for demonstration. Build & run sequencer demo to observe changes
https://github.com/napframework/nap/assets/375488/0978780b-8d1d-4569-853e-e6ce3913dcf6