napframework / nap

NAP Framework source code
https://nap-framework.tech
Mozilla Public License 2.0
410 stars 23 forks source link

Sequencer improvements #29

Closed TimGroeneboom closed 1 month ago

TimGroeneboom commented 3 months ago

See video for demonstration. Build & run sequencer demo to observe changes

https://github.com/napframework/nap/assets/375488/0978780b-8d1d-4569-853e-e6ce3913dcf6

cklosters commented 3 months ago

Thanks for the PR, I'll have time to properly review it beginning of next month.

cklosters commented 2 months ago

When I drag an event (make an edit) and try to re-load the change I get the following assert (Debug / MSVC):

https://github.com/user-attachments/assets/3fa81b94-5732-445a-9ad2-655cbbb3a0a4

TimGroeneboom commented 1 month ago

When I drag an event (make an edit) and try to re-load the change I get the following assert (Debug / MSVC):

history_edit_error.mp4

good catch, weird the crash only occurs on msvc.

fix pushed -> https://github.com/napframework/nap/pull/29/commits/7c3fd050126366180186949bb4ae3bad8697cdf0

cklosters commented 1 month ago

Thanks for the clarification @TimGroeneboom, this PR will be part of the 0.7.5 release and can be merged into main when the builds pass.

cklosters commented 1 month ago

Merci! feel free to delete branch if you don't need it anymore.