napsternxg / ReadLater

This is a google chrome extension for saving links for later reading.
https://chrome.google.com/webstore/detail/read-later/nplngmgdacdfncdkpdomipkehfnbinfa
GNU General Public License v2.0
103 stars 36 forks source link

Option: automatically close added tabs #12

Open kav2k opened 7 years ago

kav2k commented 7 years ago

Add a configuration option that will cause adding a page to automatically close that tab.

It saves a click in what is, for me, the most common use case.

An option instead of just another UI button because it should apply to shortcut / context menu as well.

I'd be glad to provide code for that.

napsternxg commented 7 years ago

This would require the inclusion of an options page. I would add it as an enhancement which can be added once we have the new API in place. I will assign this to you.

kav2k commented 7 years ago

With just one option, it can be handled in popup UI. Do you have any ideas for more options to justify options UI?

Also, this is blocked until you merge your changes to how link adding is processed.

napsternxg commented 7 years ago

Hmm, maybe a small switch in the UI to take care of this should be good. We can add this once the API is complete.

kav2k commented 7 years ago

We could make another option to hide the badge with count. That would justify options UI.

Believe it or not, but it can be anxiety-inducing ("must act now!").

Lastly, we could also enable using local storage over sync.

napsternxg commented 7 years ago

I think changing storage would be against the core idea of the extension. Also, the badge count was probably added after user feedback so I would keep that as of now.

BTW I have added some skeleton code for the new API in the branch new-api, this code is not working but I will be pushing changes there first before merging with the master version. Would you like to have a look at it and suggest changes ? We can discuss this on #16 issue page.

kav2k commented 7 years ago

It's probably going to be a checkbox. Visually, where would you like this setting to be in the popup?

Or should I opt for an options page?

napsternxg commented 7 years ago

@kav2k I was recently thinking that this behavior might not be applicable for all links. E.g. if I am reading a page and I know I will need to leave my desktop in a few minutes. If in this case I use the add to ReadLater (with the option to automatically close the tab), then I will loose the current reading session, which might not be desired. I personally use ReadLater in this setting only. I think closing the tab after adding is not such a hassle anymore as we can add the link via keyboard shortcut which makes it very easy to just do Ctrl+Shift+L and Ctrl+W on windows to just add the link to read later and then close the tab. What do you think about this? I think the introduction of keyboard shortcut solves this issue.

kav2k commented 7 years ago

Perhaps. Though the shortcut is not currently well-advertised, I think. There is no way to discover it in GUI (unless you open your extension shortcut list) and the FAQ is out of date.

I still want to contribute the context menu item, that's somewhat more visible. I just need to redo it for the new core code.

Maybe all that's needed here is a separate UI button in the popup, "ADD&CLOSE" or something along those lines.

kav2k commented 7 years ago

Also, the badge count was probably added after user feedback so I would keep that as of now.

In fact, user feedback you refer to also mentioned an option to switch it off, so ¯\_(ツ)_/¯

napsternxg commented 7 years ago

@kav2k what do you think about adding the option to add and close the current tab in the context menu. That makes things more explicit and the user has more choice without having a global setting for adding and closing.

Also, I agree the keyboard shortcut needs to be better advertised. Do you suggest we include some message when the user updates to show the new features ?

napsternxg commented 7 years ago

In fact, user feedback you refer to also mentioned an option to switch it off, so ¯_(ツ)_/¯

Haha, that was a long time ago. I didn't notice there was a request for an option to switch it off, so never implemented it. Now I think the badge just goes with the UI.

kav2k commented 7 years ago

adding the option to add and close the current tab in the context menu.

The problem with adding it to context menu: only one top-level context item can exist. Add two and it becomes a submenu with associated delay in appearing.

Do you suggest we include some message when the user updates to show the new features?

What I like to do is to have a constant in my code (and saved to storage) that increases when I feel like an update is important enough to visit the options page / changelog. Then I show a notification toast if that increases higher than the previously-stored number.


I don't want to decide for the user how it should behave. It is, in general, a problem that we, as developers, have tunnel vision as to how our apps "should" work, especially if they start out as personal tools. Adding choice is almost always a user-friendly thing to do, as long as the default is sensible. Of course, said choice comes with implementation costs, ongoing maintenance costs, and may be technically unfeasible in some ways.

Here's the "please everyone" version of context menu implementation:

kav2k commented 7 years ago

Then again, as a counterpoint, we have this:

XKCD 1172

If you added an option, no matter how unlikely to ever be used, if you take it out later you're breaking someone's workflow.

kav2k commented 7 years ago

This issue grew massively out of topic.

I propose @napsternxg decide on:

demian85 commented 6 years ago

Hi,

I just came up with an idea to create an extension just as this, but I'm also expecting the link to re removed when clicking. What do you think about using ctrl/cmd + click to keep the link and remove it by default? I may also be an option configurable in the popup UI. I can make that change if you want. Let me know.

I would also change the remove icon and fix the ugly vertical-align!

Thanks!