search

napsternxg / ReadLater

This is a google chrome extension for saving links for later reading.
https://chrome.google.com/webstore/detail/read-later/nplngmgdacdfncdkpdomipkehfnbinfa
GNU General Public License v2.0
103 stars 36 forks source link

Get rid of tabs / <all_urls> permissions #8

Closed kav2k closed 7 years ago

kav2k commented 7 years ago

activeTab permission is all the current code needs, removing all permission warnings: https://developer.chrome.com/extensions/activeTab

Also replaces deprecated tabs.getSelected call with tabs.query

angeliski commented 7 years ago

Hey @napsternxg Do you like help to revision in that pull request?

kav2k commented 7 years ago

@angeliski Considering the last meaningful change to code was 3 years ago, I doubt it. I simply plan to make a new extension in the same vein at some point..

napsternxg commented 7 years ago

Hi @kav2k and @angeliski thanks for bringing this to light again. I will merge it and update the extension soon.

kav2k commented 7 years ago

@napsternxg Apologies for the assumption, then.

Are you going to maintain this further? There are "easy pickings" improvements that can be made, and I'd be happy to submit more PRs.

napsternxg commented 7 years ago

@kav2k I would very much appreciate PR's for changes but I don't usually write more code for this extension. I never know if anyone will ever use this. So, yes if you can send some more PR's then I can merge all of them and release a new updated version soon. Please open a separate Issue for each PR though.

kav2k commented 7 years ago

@napsternxg Well, your extension still has 13,943 users as of right now..

napsternxg commented 7 years ago

@kav2k 👍 , I did check the reviews on the chrome page today. There have been a few requests for adding additional features. However, I want to keep the extension really simple with the most minimal features and working condition, so anything which doesn't change those core ideas would be easy to incorporate.