search

naqushab / saavn-downloader-extension

Chrome Extension to download songs and block ads for jiosaavn.com (previously saavn.com)
https://www.jiosaavn.com/
91 stars 18 forks source link

[BUG] Download progress bar is missing #43

Closed ADVALAKI closed 3 years ago

ADVALAKI commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to URL '...' : Open Any song
  2. Click on '....' : Click on Download button its only show clock icon. ( download progress-bar is missing)
  3. See error : BasicallySongs downloaded successfully in background. but progress bar is missing.

Expected behavior A clear and concise description of what you expected to happen. Should display download progress bar.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

naqushab commented 4 years ago

Hi @ADVALAKI , Actually after the UI overhaul i decided not to put more work on download bar on bottom as it itself is more work. And if you've seen the jiosaavn pro, the download progress is consistent with what I have provided. I'd happy to accept any PR to add it in case someone wants to add, but for now this will be an enhancement and more of a nice to have feature.

ADVALAKI commented 4 years ago

you mean to say in jiosavan pro progress bar is working fine.?

By the way you have done great work on this two days to make this extension functional again.

hats off for this. :+1:

naqushab commented 4 years ago

No. I meant there is no progress bar in JioSaavn pro as well (which has the official download option support). It also shows this downloading circle when clicked on Download icon. The progress bar changes take a lot of time and itself is quite buggy which is why I used Jiosaavn's own downloading icon and not that. Hopefully, once I am done with all functional changes I can re-look into that again.

Thank you for the kind words, and sorry I couldn't do it sooner. I got quite caught up in other stuff.

tuhinpal commented 3 years ago

@ADVALAKI , Now it will update you by some notifications. Progress bar is not practical for https://github.com/naqushab/saavn-downloader-extension/commit/d42bf2b8435733562f22161616580b947a3cc136 as it have to fetch and convert the song into mp3. So it will update you with some notifications, if your download has been failed due to some reason, it will still notify you.

naqushab commented 3 years ago

Workaround provided. Closing the issue.