naqvis / cryplot

Crystal plotting library powered by gnuplot
MIT License
22 stars 4 forks source link

Escape spaces in `$PWD` variable in `install.sh` #3

Closed SlimBenAmor closed 1 year ago

SlimBenAmor commented 1 year ago

After adding cryplot dependency to my shard.yml file and running shards install, I get this error:

Resolving dependencies
Fetching https://github.com/naqvis/cryplot.git
Installing cryplot (0.1.1)
Postinstall of cryplot: ./install.sh
Failed postinstall of cryplot on ./install.sh:
./install.sh: 5: ./install.sh: Bad substitution
./install.sh: 7: ./install.sh: pushd: not found

The problem was that my project path contains some spaces that were not escaped when calling pushd $PWD in install.sh. This pull request solves this problem by adding two double quote (") around PWD variable in install.sh.

naqvis commented 1 year ago

Thanks @SlimBenAmor