search

naqvis / webview

Crystal bindings to Webview library
MIT License
94 stars 8 forks source link

Add Github CI #26

Closed konovod closed 1 year ago

konovod commented 1 year ago

Related to #15 This PR just adds workflow, building examples is separate problem (we should add them to examples folder and decide whether to just build or to run them. And how to stop them in latter case).

naqvis commented 1 year ago

@konovod CI build failing on Windows. Do we need to update std flag to -std=c++14?

https://github.com/naqvis/webview/actions/runs/4777495206/jobs/8493266000

konovod commented 1 year ago

Yes, i'm not even sure what is g++ in windows CI (mingw64 perhaps?) and would it successfully link with crystal program (crystal uses msvc on Windows, not mingw). So i made a PR https://github.com/naqvis/webview/pull/28 with a compilation process suggested in README: it compiles webview to dll and copy lib file to crystal location.

naqvis commented 1 year ago

Thanks @konovod and yeah its good to use msvc for compilation on windows to avoid other mingw related issues. Thanks for the contributions and fixes 👍 ❤️