search

narainkarthikv / Nmoji

Open Source Project Emoji Filter & Clipboard
https://nmoji.netlify.app/
MIT License
5 stars 6 forks source link

Adjusting Styling #18

Closed pauleenaphan closed 2 weeks ago

pauleenaphan commented 2 weeks ago

What I changed:

Original: Screenshot 2024-08-28 170935

My Changes: Screenshot 2024-08-28 170858

netlify[bot] commented 2 weeks ago

Deploy Preview for nmoji ready!

Name Link
Latest commit 120d3a4c4fa310c9390416cc88dde5c0ec89ac8a
Latest deploy log https://app.netlify.com/sites/nmoji/deploys/66cfbc771df7d80008e34fbc
Deploy Preview https://deploy-preview-18--nmoji.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pauleenaphan commented 2 weeks ago

Hi, sorry I forgot to add but I am super new to contributions. Was I supposed to make an issue first then wait to be assigned, then created a pull request?

narainkarthikv commented 2 weeks ago

Hi, sorry I forgot to add but I am super new to contributions. Was I supposed to make an issue first then wait to be assigned, then created a pull request?

No worries! I'm currently handling code reviews. Feel free to tackle any bugs or tweaks you'd like to work on.

pauleenaphan commented 2 weeks ago

Sounds good thank you! Although is it good practice to write an issue first then create a pull request? Or is it okay to just create a pull request.

narainkarthikv commented 2 weeks ago

Sounds good thank you! Although is it good practice to write an issue first then create a pull request? Or is it okay to just create a pull request.

The standard procedure is to raise an issue and then submit a PR, so please follow this process consistently. For now, I'm regularly checking GitHub, so don't worry too much about raising an issue. However, it would be helpful to let me know in advance about the issue you're working on.

pauleenaphan commented 2 weeks ago

Oh okay. Thank you!