search

narayan954 / dummygram

DummyGram is a social media application where we have posts, stories, chat, friends, authentication, comment, delete, share and like feature. It uses ReactJs in the frontend for the UI and Firebase for the backend storing the users, posts, stories and comments.
https://narayan954.github.io/dummygram/
MIT License
76 stars 185 forks source link

Sign Up Button Design Enhancement #1200

Closed iamRabia-N closed 1 year ago

iamRabia-N commented 1 year ago

This pull request contains the updated code for '[FEATURE] -Sign Up Button Design Enhancement'. The issue related to this pull request is as follows:

[FEATURE] -Sign Up Button Design Enhancement #1171

Output Screenshot

ip (3)

iamRabia-N commented 1 year ago

Hi @narayan954 The bug is resolved in commit with id '2bae451299504e370ff83431dd775be27a560b8e'.

Output Screenshot

Screenshot (2679)

Screenshot (2678)

narayan954 commented 1 year ago

Hi @narayan954 The bug is resolved in commit with id '2bae451299504e370ff83431dd775be27a560b8e'.

Output Screenshot

Screenshot (2679)

Screenshot (2678)

thanks a lot! :)

iamRabia-N commented 1 year ago

Yeah, I am working on implementing this logic.

narayan954 commented 1 year ago

Hi @iamRabia-N still the css is breaking layout, as you can see image and image

Can't we do something like, create a separate class for this margin-top and add this class only when user is anonymous?

also to give you more info, in suggestion component, we have variable currentUser and it has a method currentUser.isAnonymous, which tells if it's an anonymous user, use this logic to add the separate class to the component

iamRabia-N commented 1 year ago

Hi @narayan954 I have tried the logic (we discussed yesterday) in jsx file . Its' not working.

narayan954 commented 1 year ago

Hi @narayan954 I have tried the logic (we discussed yesterday) in jsx file . Its' not working.

Hi @iamRabia-N I checked and was able to solve it using that logic only, Do allow me to edit this pr and I'll push the fixes. Also, there're some errors in routing that was causing another issue, I fixed those in those commits as well!

narayan954 commented 1 year ago

around here @iamRabia-N you'll get the option to enable edits by maintainer option image

It's a good practise that you enable modifications by maintainer.

iamRabia-N commented 1 year ago

@narayan954 You can edit this pull request now.